Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List DID Rules will give 200 even if DID does not exist #6334

Closed
ThePhisch opened this issue Sep 18, 2023 · 1 comment · Fixed by #6384
Closed

List DID Rules will give 200 even if DID does not exist #6334

ThePhisch opened this issue Sep 18, 2023 · 1 comment · Fixed by #6384
Assignees
@alexanderrichards
Labels
bug Rules
Milestone
33.1.0

Comments

@ThePhisch
Copy link
Contributor

Description

Rucio will return a 200 OK when querying DID Rules even when the scopename is invalid.

Steps to reproduce

  1. GET /dids/<scope>/<name>/rules
  2. get a 200 OK even if the scopename is not valid

Rucio Version

32.3.0

Additional Information

Discovered while developing the WebUI
@ThePhisch ThePhisch added the bug label Sep 18, 2023
@bari12 bari12 assigned bari12 and unassigned bari12 Sep 20, 2023
@bari12 bari12 added the Rules label Sep 20, 2023
@alexanderrichards
Copy link
Contributor

alexanderrichards commented Nov 20, 2023 •
edited

Just for confirmation, when I look at the OpenAPI documentation for the REST interface I see an endpoint that is slightly different from the one you sepcify (see /dids/{scope_name}/rules ). Notably the scope and name are combined into the single {scope_name} element. Is this the same endpoint that causing a problem?

Edit: Never mind, I see that there is a regex that is splitting the single scope_name into the two seperarte entities.

alexanderrichards added a commit to alexanderrichards/rucio that referenced this issue Nov 22, 2023
@alexanderrichards
Rules: Return 404 when DID rules not found. Fixes rucio#6334
01aa218
@alexanderrichards alexanderrichards mentioned this issue Nov 22, 2023
Merged
alexanderrichards added a commit to alexanderrichards/rucio that referenced this issue Nov 22, 2023
@alexanderrichards
Rules: Return 404 when DID rules not found. Fixes rucio#6334
1fd25ec
alexanderrichards added a commit to alexanderrichards/rucio that referenced this issue Nov 29, 2023
@alexanderrichards
Rules: Return 404 when DID rules not found. Fixes rucio#6334
16bb6f9
alexanderrichards added a commit to alexanderrichards/rucio that referenced this issue Nov 29, 2023
@alexanderrichards
Rules: Return 404 when DID rules not found. Fixes rucio#6334
d01b01f
bari12 pushed a commit that referenced this issue Dec 18, 2023
@alexanderrichards @bari12
Rules: Return 404 when DID rules not found. Fixes #6334
1081588
bari12 pushed a commit that referenced this issue Dec 18, 2023
@alexanderrichards @bari12
Rules: Return 404 when DID rules not found. Fixes #6334
328ecbe
@bari12 bari12 modified the milestones: 32.6.1 / 32.7.0, 33.1.0 Dec 18, 2023
voetberg pushed a commit to voetberg/rucio that referenced this issue Apr 15, 2024
@alexanderrichards @voetberg
Rules: Return 404 when DID rules not found. Fixes rucio#6334
249e66b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderrichards alexanderrichards

Labels
bug Rules
Projects
None yet
Milestone
33.1.0
Development

Successfully merging a pull request may close this issue.

Rules: Return 404 when DID rules not found #6334 alexanderrichards/rucio
3 participants
@bari12 @alexanderrichards @ThePhisch