fix for SSR #7
Closed
fix for SSR #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix will render the component text on server. earlier, it was only rendering this on the client
alexandersmanning
requested changes
Mar 5, 2019
| @@ -8,7 +8,7 @@ export default class ReadMoreReact extends React.Component { | |||
| this.state = { displaySecondary: false, primaryText: "", secondaryText: "", readMoreText: this.props.readMoreText }; | |||
| } | |||
|
|
|||
| componentDidMount() { | |||
There was a problem hiding this comment.
ComponentWillMount is being deprecated, I can put it in the constructor but want to verify if that is the right path forward:
styled-components/styled-components#1575
|
Updated to be in the constructor, see version 1.09 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix will render the component text on server.
earlier, it was only rendering this on the client