Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google AdSense support #47

Closed
alexandrevicenzi opened this issue Aug 2, 2016 · 12 comments
Closed

Google AdSense support #47

alexandrevicenzi opened this issue Aug 2, 2016 · 12 comments
Labels
Milestone

Comments

@alexandrevicenzi
Copy link
Owner

Well, it's very common and useful. But the question is: Where must the banners be placed?

It's not good to add 10 banners per page. One is annoying, so it must be something careful, or not done at all.

Just thinking about this today.

@gustavofoa
Copy link

I think it makes sense a reponsive adsense banner on top/bottom of articles.

I've just implemented it in a fork. I'm going to PR for your apreciation.

@alexandrevicenzi
Copy link
Owner Author

alexandrevicenzi commented Sep 14, 2016

I think it's good to have more than two options. We could allow up to 5 places somewhere and the user choose where to place.

For example:

ADSENSE = {
  'aside': 'some-id',
  'article-bottom': 'another-id',
  //  ....
}

@gustavofoa
Copy link

Nice! Which other places do you think good to add banners?

Do you agree to support only responsible banners?

@alexandrevicenzi
Copy link
Owner Author

For all pages (Scenario 1):

image

For Home only (Scenario 2):

image

For articles (Scenario 3):

image

Pages doesn't need banners near content I think. Scenario 1 is good.

We can combine scenarios 1 + 2 and 1 + 3.

Just an idea. You can suggest other places too.

@alexandrevicenzi
Copy link
Owner Author

In my case I think I'll use only aside and article bottom. Two banners are good for me.

But we could allow up to 5 places.

@gustavofoa
Copy link

Good idea, I'll try to implement it.

@alexandrevicenzi
Copy link
Owner Author

Here where to place:

Before closing aside (inside aside).
Before open nav.
After closing article (for single page only).
After article for-loop (for home only).

@gustavofoa
Copy link

Only responsible banners. Right?

@alexandrevicenzi
Copy link
Owner Author

Not sure how they will work. As far I know AdSense works good with responsible banners, but we need to try.

For example, aside must be a square banner, not sure if Google will know this. But we can try.

@gustavofoa
Copy link

The responsible banner, on load time, adapts for the browser. You can see it working here: http://gustavofurtado.com.br/seja-bom-no-essencial-programador.html

Open it in your smartphone and open it in a desktop to see the difference.

image

image

image

But when you resize your browser width after load the page, the banner keeps the size adjusted when it loaded.

image

@alexandrevicenzi
Copy link
Owner Author

Good.

Did you know that you can use Flex in pt_BR (aka HUEHUEHUEBR)?

@gustavofoa
Copy link

Yes, I know. I've just forgot to configurate. rsrs

alexandrevicenzi added a commit that referenced this issue Nov 8, 2016
@alexandrevicenzi alexandrevicenzi added this to the 2.1 milestone Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants