Support for responsive adsense banners #56
Conversation
| @@ -25,6 +25,16 @@ The minimalist [Pelican](http://blog.getpelican.com/) theme. | |||
| - [Piwik](http://piwik.org/) | |||
| - [StatusCake](https://www.statuscake.com/) | |||
|
|
|||
| ## Adsense banner | |||
There was a problem hiding this comment.
Settings are documented on Wiki.
|
@gustavofoa nice, but take a look in my comment at #47 |
|
@gustavofoa is this OK? |
|
It is Ok for me. |
There was a problem hiding this comment.
Looks like if a user uses more than one banner it will load ads JS for each banner, this is a shot in the foot, it will increase page load a lot.
JSs file should be loaded async at the page bottom, but as always google want's to load stuff in the head to keep it slow AF. Not sure if it will work, but adsense docs will say it.
Looks like GitHub is having problems, but I'll change the branch of this PR to another, so it wont break anything.
Also, I'll fix this PR tomorrow.
| @@ -77,3 +77,13 @@ | |||
| ADD_THIS_ID = 'ra-XX3242XX' | |||
|
|
|||
| USE_LESS = True | |||
|
|
|||
| ADSENSE = { | |||
| 'adClientId' : 'ca-pub-XXXXXXXXXXXXXXXX', | |||
There was a problem hiding this comment.
Variables should user only _ not camelCase mixed
I included support to responsive adsense banners on top/bottom of articles and index. And on bottom of aside.