Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Google Tag Manager targets #142

Merged
merged 2 commits into from
Jan 8, 2018

Conversation

rhyven
Copy link
Contributor

@rhyven rhyven commented Jan 6, 2018

The old way of pulling in the source elements (e.g. j.src='//www...') no longer works. It now needs the protocol as well (e.g. j.src='https://www...').

I noticed this start happening on the 8th of December. Not sure what changed, but it wasn't happening before that as far as I can tell.

I've updated the src location to include the protocol. This has solved the issue for me.

@alexandrevicenzi alexandrevicenzi merged commit fc0724e into alexandrevicenzi:master Jan 8, 2018
@alexandrevicenzi alexandrevicenzi added this to the 2.2.0 milestone Jan 8, 2018
@alexandrevicenzi
Copy link
Owner

Thanks @rhyven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants