Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rule 2.11 to discourage use of joda-time in favour of java.time #44

Closed
jjst opened this issue Jun 6, 2017 · 3 comments
Closed

Comments

@jjst
Copy link
Contributor

jjst commented Jun 6, 2017

Rule 2.11 states:

2.11. MUST NOT use Java's Date or Calendar, instead use Joda-Time or JSR-310

JSR-310 has now been implemented as Java 8's new java.time API and even jodatime's website is asking users to migrate:

Joda-Time is the de facto standard date and time library for Java prior to Java SE 8. Users are now asked to migrate to java.time (JSR-310).

As Java 8 has become more and more common, it's probably time to deemphasise joda-time and recommend the java.time API as the standard approach, with joda-time as a fallback for people stuck in pre-Java 8 land.

@frgomes
Copy link

frgomes commented Jun 6, 2017

indeed! +1

@alexandru
Copy link
Owner

Sure. Any of you up for a PR?

@jjst
Copy link
Contributor Author

jjst commented Jun 6, 2017 via email

jjst added a commit to jjst/scala-best-practices that referenced this issue Jun 7, 2017
jjst added a commit to jjst/scala-best-practices that referenced this issue Jun 7, 2017
alexandru added a commit that referenced this issue Jun 12, 2017
2.11: Favour java.time over joda-time ⌚ (fixes #44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants