Sfall: add VersionString, ConfigFile, PatchFile #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobos2077
reviewed
Jun 16, 2023
| for (patch_index = 0; patch_index < 1000; patch_index++) { | ||
| snprintf(filename, sizeof(filename), "patch%03d.dat", patch_index); | ||
| snprintf(filename, sizeof(filename), patch_filename, patch_index); |
There was a problem hiding this comment.
Do we really need this option? Any mod relies on it? We have a much better mods system in sfall 4.x. All this patch stuff is relics from early modding years.
There was a problem hiding this comment.
Patches is still vanilla engine feature, so i guess 'll be better have to stay that thing.
There was a problem hiding this comment.
I'm talking about patch stuff added by sfall, that nobody uses now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds three misc Sfall options for overriding version string, game config file name and patch file name. Tested with Olympus and its ddraw.ini options.
Part of #29 - Misc patches module.