Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive cleanup #2

Merged
merged 7 commits into from Oct 6, 2020
Merged

Massive cleanup #2

merged 7 commits into from Oct 6, 2020

Conversation

malte-v
Copy link
Collaborator

@malte-v malte-v commented Oct 5, 2020

Things done:

  • By @purefn: Added support for plain authentication
  • Updated some code to work with recent versions of the networking package
  • Moved everything from Web.Postie to Network.Mail.Postie (email doesn't have much to do with the web ;))
  • Cleaned up remaining compiler and HLint warnings
  • Formatted everything
  • Added Nix support (now compiles with nixpkgs-unstable)

The new networking code seems to be working fine. I'm able to have an SMTP session with the server via telnet on both IPv4 and IPv6.

A major release on Hackage after this gets merged would be much appreciated!

@alexbiehl
Copy link
Owner

Awesome! Great work. Do you think we should remove the stupid session uuid thing as well? I always found it to be strange. Wonder how we would organize it differently but maybe you have an idea.

Copy link
Owner

@alexbiehl alexbiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fire away!

@malte-v
Copy link
Collaborator Author

malte-v commented Oct 6, 2020

Do you think we should remove the stupid session uuid thing as well?

Not sure... What was the rationale for introducing it? I honestly don't know much about SMTP at all, I just want to receive some email so I'm probably not the best person to ask.

@malte-v
Copy link
Collaborator Author

malte-v commented Oct 6, 2020

Oh sure, it's for keeping the clients apart. I think we do need some sort of session identifier for that, so I would just leave it as is.

@malte-v
Copy link
Collaborator Author

malte-v commented Oct 6, 2020

So can you merge and release this now? :3

@alexbiehl
Copy link
Owner

What's your hackage handle?

@malte-v
Copy link
Collaborator Author

malte-v commented Oct 6, 2020

It's malvo. I don't have upload permissions yet though because the Hackage mailserver doesn't accept my email :/

@alexbiehl
Copy link
Owner

alexbiehl commented Oct 6, 2020

You are now a maintainer for postie on hackage. I won't be around a computer for the next two weeks.

@malte-v
Copy link
Collaborator Author

malte-v commented Oct 6, 2020

Great, thanks!

@malte-v malte-v merged commit 5c19616 into alexbiehl:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants