Don't force PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Regardless of whether this idea was good or not it's part of the stable interface of pkg-config and I'd prefer to not have a breaking change just yet. Perhaps a boolean option could be added though to disable this behavior? |
|
I'd say it's really easy to add the env variable should a user need it ? I agree this is a breaking change though... |
|
To be clear, this is a breaking change, so it can't be merged as-is. We can add a boolean option to the builder, however, to disable this and perhaps change the default behavior in the next major version. |
|
It is possible to work around this by using a different part of the pkg-config API. But non-obvious. |
|
Added in d184e48 |
|
+1 for making this the default, the current behaviour is pretty broken when multiple versions of the same library are present |
MathieuDuponchelle
added a commit
to MathieuDuponchelle/sys
that referenced
this pull request
Feb 21, 2018
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-sys
that referenced
this pull request
Feb 21, 2018
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gstreamer-sys
that referenced
this pull request
Feb 21, 2018
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
sdroege
pushed a commit
to sdroege/gstreamer-sys
that referenced
this pull request
Feb 21, 2018
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/gir
that referenced
this pull request
Feb 23, 2018
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
vhdirk
pushed a commit
to vhdirk/gir
that referenced
this pull request
Jul 6, 2018
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS environment variable (rust-lang/pkg-config-rs#35), which leads to eg /usr/lib being present in the middle of the final command, in turn leading to issues when working in an uninstalled environment, where libraries that are also present system-wide do not get linked against.
gdesmott
pushed a commit
to gdesmott/system-deps
that referenced
this pull request
May 1, 2020
For some reason pkg-config-rs sets PKG_CONFIG_ALLOW_SYSTEM_LIBS by default, breaking uninstalled builds, see rust-lang/pkg-config-rs#35 Users should manually enable this if needed, by defining the env variable, and should not be enforced by the build system.
gdesmott
pushed a commit
to gdesmott/system-deps
that referenced
this pull request
May 2, 2020
For some reason pkg-config-rs sets PKG_CONFIG_ALLOW_SYSTEM_LIBS by default, breaking uninstalled builds, see rust-lang/pkg-config-rs#35 Users should manually enable this if needed, by defining the env variable, and should not be enforced by the build system.
gdesmott
pushed a commit
to gdesmott/system-deps
that referenced
this pull request
May 3, 2020
For some reason pkg-config-rs sets PKG_CONFIG_ALLOW_SYSTEM_LIBS by default, breaking uninstalled builds, see rust-lang/pkg-config-rs#35 Users should manually enable this if needed, by defining the env variable, and should not be enforced by the build system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea if this change in behavior is acceptable. Seems like a bad default, though.
Per #11 (comment)