all around: disable print_system_libs in calls to pkg-config #80
Conversation
|
Confirming that it still worked on windows/msys2 64 |
|
@EPashkin thanks for checking, as far as I understand, this sort of "default" system paths are better left to the compiler |
|
Should this go in then? :) |
| @@ -47,6 +47,7 @@ fn find() -> Result<(), Error> { | |||
|
|
|||
| let mut config = Config::new(); | |||
| config.atleast_version(version); | |||
| config.print_system_libs(false); | |||
There was a problem hiding this comment.
Actually this change need be done in gir before and this PR need change as regen with Gir submodule update
There was a problem hiding this comment.
Ah didn't know this was generated, proposed gtk-rs/gir#553, thanks!
MathieuDuponchelle
force-pushed
the
master
branch
from
3df193b
to
8f1bc62
Compare
gio-sys/src/lib.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| // This file was generated by gir (https://github.com/gtk-rs/gir @ ea993ed) | |||
| // This file was generated by gir (https://github.com/gtk-rs/gir @ a418513) | |||
There was a problem hiding this comment.
gir sub-module updated to 6114d1c7e2, but here commit before merge.
I usually touch gir's Cargo.toml to regen after my gir commit merged to get right version.
MathieuDuponchelle
force-pushed
the
master
branch
from
8f1bc62
to
41a3d76
Compare
|
@MathieuDuponchelle Thanks |
|
Thanks! |
|
That change is already in gstreamer-sys :) go ahead |
By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS
environment variable
(rust-lang/pkg-config-rs#35), which leads
to eg /usr/lib being present in the middle of the final command,
in turn leading to issues when working in an uninstalled environment,
where libraries that are also present system-wide do not get linked
against.