New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all around: disable print_system_libs in calls to pkg-config #80

Merged
merged 1 commit into from Feb 24, 2018

Conversation

Projects
None yet
4 participants
@MathieuDuponchelle
Contributor

MathieuDuponchelle commented Feb 21, 2018

By default, pkg-config-rs sets the PKG_CONFIG_ALLOW_SYSTEM_LIBS
environment variable
(alexcrichton/pkg-config-rs#35), which leads
to eg /usr/lib being present in the middle of the final command,
in turn leading to issues when working in an uninstalled environment,
where libraries that are also present system-wide do not get linked
against.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 21, 2018

Confirming that it still worked on windows/msys2 64

@MathieuDuponchelle

This comment has been minimized.

Contributor

MathieuDuponchelle commented Feb 21, 2018

@EPashkin thanks for checking, as far as I understand, this sort of "default" system paths are better left to the compiler

@MathieuDuponchelle

This comment has been minimized.

Contributor

MathieuDuponchelle commented Feb 23, 2018

Should this go in then? :)

@@ -47,6 +47,7 @@ fn find() -> Result<(), Error> {
let mut config = Config::new();
config.atleast_version(version);
config.print_system_libs(false);

This comment has been minimized.

@EPashkin

EPashkin Feb 23, 2018

Member

Actually this change need be done in gir before and this PR need change as regen with Gir submodule update

This comment has been minimized.

@MathieuDuponchelle

MathieuDuponchelle Feb 23, 2018

Contributor

Ah didn't know this was generated, proposed gtk-rs/gir#553, thanks!

This comment has been minimized.

@MathieuDuponchelle
@@ -1,4 +1,4 @@
// This file was generated by gir (https://github.com/gtk-rs/gir @ ea993ed)
// This file was generated by gir (https://github.com/gtk-rs/gir @ a418513)

This comment has been minimized.

@EPashkin

EPashkin Feb 23, 2018

Member

gir sub-module updated to 6114d1c7e2, but here commit before merge.
I usually touch gir's Cargo.toml to regen after my gir commit merged to get right version.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 24, 2018

@MathieuDuponchelle Thanks
@GuillaumeGomez LGFM and works for me (windows).
cc @sdroege just in case

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 24, 2018

Thanks!

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 24, 2018

That change is already in gstreamer-sys :) go ahead

@GuillaumeGomez GuillaumeGomez merged commit 3b99cf7 into gtk-rs:master Feb 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment