Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing input read files do not throw errors and arguably should #843

Open
malcook opened this issue Feb 21, 2020 · 4 comments
Open

missing input read files do not throw errors and arguably should #843

malcook opened this issue Feb 21, 2020 · 4 comments

Comments

@malcook
Copy link

malcook commented Feb 21, 2020

STAR would benefit from catching and raising an error if reading from the input read filesitself raises an error.

At least in one case it does not, namely when --readFilesCommand zcat -f and the --readFilesIn f1,f2,f3 do not exist.

The Log shows it as follows:

ls: cannot access f1: No such file or directory
ls: cannot access f2: No such file or directory
ls: cannot access f3: No such file or directory

Certainly the system call to ls raising an error.

If STAR would itself throw an error in such cases, it would improve the user experience in using it.

@alexdobin
Copy link
Owner

Good suggestion - thanks, Malcolm!

alexdobin added a commit that referenced this issue May 27, 2020
…ot exist when using --readFilesCommand .
@alexdobin
Copy link
Owner

Hi Malcolm

I have pushed a patch into master that fixes this problem, please check it out. There will be an official 2.7.3b release in the next few days.

Cheers
Alex

@malcook
Copy link
Author

malcook commented Jun 6, 2021

Finally testing now with version 2.7.9a, I still find that STAR does not raise an error when a file named in readFilesIn does not exist, and does not (at least in combination with --readFilesCommand zcat -f).

;(

@alexdobin alexdobin added this to the Crucial Enhancements milestone Jun 9, 2021
@alexdobin
Copy link
Owner

Hi Malcolm,

thanks for bumping it, will implement this check in the next release.

Cheers
Alex

alexdobin added a commit that referenced this issue Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants