DecodeHash fixes #24
Open
DecodeHash fixes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
commented
Nov 13, 2023
| return nil, nil, nil, err | ||
| } | ||
|
|
||
| rest, err := ioutil.ReadAll(r) |
There was a problem hiding this comment.
ioutil is deprecated, could use io.ReadAll if we can assume Go 1.16+. The only info in the package I could locate about the supported version is 1.12 in go.mod.
Sscanf silently ignores it. Rewrite using a reader so we can make use of the parse position to detect it. The errors returned are not exactly the same for the same input as before. In particular, scanf originated parse errors rather than ErrInvalidHash are now returned for more inputs. For completeness, includes tests for leading parameter junk, although that was not a problem before either. Could be somewhat faster and allocate less than the previous implementation, too (no benchmarks run).
Return ErrInvalidHash on any.
|
This looks great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits and their messages for details.