Refactor into pkg using an options input and add Loki App #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing? |
Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Waterdrips
force-pushed
the
waterdrips-loki
branch
from
9e0cd4d
to
ac90ec2
Compare
missed committing after fmt. Apologies |
|
@Waterdrips could you work on the Loki app for the openfaas component from @LucasRoesler? I would probably suggest calling it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alistair Hey alistair@heyal.co.uk
Refactor into pkg for creating apps using a "options" block passed into the specific apps.
See #21
Add Loki app, first part of #115
Description
Refactor some of the common stuff out into pkg, creating a "InstallerOptions" struct that would be passed to the pkg function that does the install. This would allow other programs to use these functions to install the apps (once migrated)
The Loki app has also been added
Motivation and Context
[App] - Add Loki for log indexing/viewing and integration to OpenFaaS #115 Remove duplication via Go chaining/structs/WithOptions() #21
How Has This Been Tested?
Installed Loki, Loki with Grafana, OpenFaaS, cert-manager, ingress-nginx, minio
and verified they installed without errors
Types of changes
Checklist:
git commit -sI dont have any ARM booted, but there's a closed issue pointing at ARM support in the repo ARM Support for promtail and Loki grafana/loki#653 (comment)