Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool: add kubectx #124

Merged
merged 1 commit into from
Jun 18, 2020
Merged

tool: add kubectx #124

merged 1 commit into from
Jun 18, 2020

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Jun 16, 2020

Attempt to fix #122: add kubectx tool

Description

Add kubectx tool

Motivation and Context

Attempt to fix #122

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

./arkade get kubectx returns the following

Downloading kubectx
https://github.com/ahmetb/kubectx/releases/download/v0.9.0/kubectx
Tool written to: /var/folders/f4/n75bkdn53jggf20nwxst39ym0000gn/T/kubectx

Run the following to copy to install the tool:

chmod +x /var/folders/f4/n75bkdn53jggf20nwxst39ym0000gn/T/kubectx
sudo install -m 755 /var/folders/f4/n75bkdn53jggf20nwxst39ym0000gn/T/kubectx /usr/local/bin/kubectx

tested the print instruction and it works locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have tested this on arm, or have added code to prevent deployment

@derek
Copy link

derek bot commented Jun 16, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@alexellis
Copy link
Owner

Hi @tuananh thanks for your interest. You'll need to go back and fill out the whole PR template which specifically asks you "how did you test this?" :-)

https://github.com/alexellis/arkade/blob/master/.github/PULL_REQUEST_TEMPLATE.md

I understand if some people feel that asking for testing is too much to ask, in which case feel free to close your PR.

For the commit message, we also use a brief sentence starting a verb in the imperative singular for instance: Add kubectx as a tool, you can edit this with git commit -s --amend

Alex

@alexellis
Copy link
Owner

Hi, you're going to have to read the readme of the project to find out, and decide if you want to contribute this properly or to close your PR.

Alex

@tuananh
Copy link
Contributor Author

tuananh commented Jun 16, 2020

@alexellis i made the changes. appreciate if you can take another look.

I also would like to tackle on #123 if this one can be merged.

cmd/get.go Show resolved Hide resolved
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot better and thanks for testing. Can you show that kubectx actually worked once downloaded and chmod'd?

I would like to see the commits squashed into one, you can find how how to do that on google "squash commits" (git rebase -I HEAD~N where N is the amount of commits you made)

Also - we'll need a fix for the comment about Windows users, or they will end up with a bash file for kubectx with a .exe suffix, which won't work.

@tuananh
Copy link
Contributor Author

tuananh commented Jun 17, 2020

This looks a lot better and thanks for testing. Can you show that kubectx actually worked once downloaded and chmod'd?

I would like to see the commits squashed into one, you can find how how to do that on google "squash commits" (git rebase -I HEAD~N where N is the amount of commits you made)

Also - we'll need a fix for the comment about Windows users, or they will end up with a bash file for kubectx with a .exe suffix, which won't work.

image

Update as per comment.

Signed-off-by: Tuan Anh Tran <me@tuananh.org>
@alexellis
Copy link
Owner

This looks excellent. You really turned this around into a top quality contribution.

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 18c2522 into alexellis:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tool] Download kubectx bash script
3 participants