-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool: add kubectx #124
tool: add kubectx #124
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Hi @tuananh thanks for your interest. You'll need to go back and fill out the whole PR template which specifically asks you "how did you test this?" :-) https://github.com/alexellis/arkade/blob/master/.github/PULL_REQUEST_TEMPLATE.md I understand if some people feel that asking for testing is too much to ask, in which case feel free to close your PR. For the commit message, we also use a brief sentence starting a verb in the imperative singular for instance: Alex |
Hi, you're going to have to read the readme of the project to find out, and decide if you want to contribute this properly or to close your PR. Alex |
@alexellis i made the changes. appreciate if you can take another look. I also would like to tackle on #123 if this one can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a lot better and thanks for testing. Can you show that kubectx actually worked once downloaded and chmod
'd?
I would like to see the commits squashed into one, you can find how how to do that on google "squash commits" (git rebase -I HEAD~N
where N is the amount of commits you made)
Also - we'll need a fix for the comment about Windows users, or they will end up with a bash file for kubectx with a .exe suffix, which won't work.
Update as per comment. |
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
This looks excellent. You really turned this around into a top quality contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Attempt to fix #122: add kubectx tool
Description
Add kubectx tool
Motivation and Context
Attempt to fix #122
How Has This Been Tested?
./arkade get kubectx
returns the followingtested the print instruction and it works locally
Types of changes
Checklist:
git commit -s