Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tgz/zip archives to the get command #133

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

alexellis
Copy link
Owner

Add support for tgz/zip archives to the get command

Description

Introduces support for "get" command to use tgz and zip archives
and adds helm3 option to "get" command.

This commit squashes three commits from PR #130 and closes #130.

Signed-off-by: Tuan Anh Tran me@tuananh.org
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com

Motivation and Context

Closes #123

How Has This Been Tested?

Tested by the author

This commit squashes the three plus the merge commit.

@alexellis alexellis force-pushed the openfaasltd/support-arkade-get-tgz-zip branch from a5de00a to 1fc844a Compare June 19, 2020 19:51
Introduces support for "get" command to use tgz and zip archives
and adds helm3 option to "get" command.

This commit squashes three commits from PR #130 and closes #130.

Signed-off-by: Tuan Anh Tran <me@tuananh.org>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis force-pushed the openfaasltd/support-arkade-get-tgz-zip branch from 1fc844a to 47c2fbd Compare June 19, 2020 19:52
@alexellis
Copy link
Owner Author

@tuananh I've squashed your three commits from #130 and added a couple of notes.

@alexellis alexellis merged commit 39f2794 into master Jun 19, 2020
@alexellis alexellis deleted the openfaasltd/support-arkade-get-tgz-zip branch June 19, 2020 19:54
@tuananh
Copy link
Contributor

tuananh commented Jun 19, 2020

@alexellis thank you. btw, i'm looking to learn golang atm so if there's anything beginner level, feel free to ping me. I would love to learn by contributing to OSS projects.

i'll scan the issue backlog in the mean time.

@alexellis
Copy link
Owner Author

Yes of course. I see you're on OpenFaaS slack. Let's coordinate there. We're always looking for people who are keen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tools] - arkade get should be able to cope with tgz/zip and multi-file archives
2 participants