Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the path on loki helm install #134

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

Waterdrips
Copy link
Contributor

Missing a split on the "/" in chart name so we installed the chart as "loki/loki-stack" rather than loki.

Tested by removing all references to loki from my helm3 repo ls

then used `go build && ./arkade install loki" which worked.

Fixes #132

Signed-off-by: Alistair Hey alistair@heyal.co.uk

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

see above

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
@@ -124,6 +124,11 @@ func AddHelmRepo(name, url string, update, helm3 bool) error {
if helm3 {
subdir = "helm3"
}

Copy link
Owner

@alexellis alexellis Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here to explain what is happening? This didn't seem to be necessary for any of the other apps? Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i missed updating this before the PR was merged,

Its done so we can use 1 generic name in the new LokiOptions -> Heml -> Repo -> Name section.
All the other apps pass in just the chart name, not repo/chart - this is backward compatible as other apps pass in the chart section only.

@alexellis alexellis merged commit 7781e43 into alexellis:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with Loki app prevents installation
2 participants