Consolidate list of apps and reduce repetition #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waterdrips
force-pushed
the
waterdrips-simplify-app-list
branch
from
12ae896
to
fe7d218
Compare
|
@alexellis WDYT? |
alexellis
reviewed
Aug 9, 2020
Waterdrips
force-pushed
the
waterdrips-simplify-app-list
branch
3 times, most recently
from
97766af
to
a1547bc
Compare
Waterdrips
force-pushed
the
waterdrips-simplify-app-list
branch
2 times, most recently
from
abd7ae4
to
3fc8aad
Compare
alexellis
reviewed
Oct 14, 2020
alexellis
reviewed
Oct 14, 2020
alexellis
reviewed
Oct 14, 2020
alexellis
reviewed
Oct 14, 2020
alexellis
requested changes
Oct 14, 2020
|
Thanks, Ill continue to work on it based on the comments |
Waterdrips
force-pushed
the
waterdrips-simplify-app-list
branch
from
3fc8aad
to
0646dee
Compare
|
Requested changes implemented |
Waterdrips
force-pushed
the
waterdrips-simplify-app-list
branch
2 times, most recently
from
5843643
to
a3b6223
Compare
To add an app previously it was very easy to miss adding it's info to the info command. This changes the way of adding an app to building a list of app "objects" and then using this list to get the info message and the installer command. Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Waterdrips
force-pushed
the
waterdrips-simplify-app-list
branch
from
a3b6223
to
ab3e91a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To add an app previously it was very easy to miss adding it's info to the
info command. This changes the way of adding an app to building a list of
app "objects" and then using this list to get the info message and the
installer command.
I found a few apps which hadn't been added to the info command, probably because it was missed as its yet another thing to add!
Signed-off-by: Alistair Hey alistair@heyal.co.uk
Motivation and Context
[ Proposal ] Remove duplication when adding a new app command #162
How Has This Been Tested?
running install and info on apps.
worked as before
Types of changes
Checklist:
git commit -s