Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faas-cli binary template for linux amd64 #175

Merged

Conversation

Waterdrips
Copy link
Contributor

Description

faas-cli binary template did not have a amd64 linux branch in the
template.
This was reported under #173

Tested on linux amd64

Signed-off-by: Alistair Hey alistair@heyal.co.uk

Motivation and Context

How Has This Been Tested?

go build
./arkade get faas-cli

Downloading faas-cli
https://github.com/openfaas/faas-cli/releases/download/0.12.8/faas-cli
Tool written to: /tmp/faas-cli

Run the following to copy to install the tool:

chmod +x /tmp/faas-cli
sudo install -m 755 /tmp/faas-cli /usr/local/bin/faas-cli

On amd64 linux

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have tested this on arm, or have added code to prevent deployment

faas-cli binary template did not have a amd64 linux branch in the
template.
 This was reported under alexellis#173

Tested on linux amd64

Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis
Copy link
Owner

Is there a unit test that could be added for regression testing? Did I miss this scenario in the tests?

@alexellis
Copy link
Owner

I can do the test..

@alexellis alexellis merged commit 8c0b60f into alexellis:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants