Fix basic-auth on re-run to disable basic auth #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
reviewed
Oct 14, 2020
alexellis
reviewed
Oct 14, 2020
alexellis
reviewed
Oct 14, 2020
| directFunctions, _ := command.Flags().GetBool("direct-functions") | ||
| directFunctionsVal := "true" |
There was a problem hiding this comment.
Are you sure that the behaviour replaced here is the same as before?
There was a problem hiding this comment.
fairly sure - the command printed to console
Command: /home/heyal/.arkade/bin/helm [upgrade --install openfaas openfaas/openfaas --namespace openfaas --wait --values /tmp/charts/openfaas/values.yaml --set openfaasImagePullPolicy=IfNotPresent --set faasnetes.imagePullPolicy=Always --set basicAuthPlugin.replicas=1 --set ingressOperator.create=false --set queueWorker.maxInflight=1 --set clusterRole=false --set gateway.directFunctions=true --set operator.create=false --set gateway.replicas=1 --set queueWorker.replicas=1 --set basic_auth=true --set serviceType=NodePort]
and the raw map printed
map[basicAuthPlugin.replicas:1 basic_auth:true clusterRole:false faasnetes.imagePullPolicy:Always gateway.directFunctions:true gateway.replicas:1 ingressOperator.create:false openfaasImagePullPolicy:IfNotPresent operator.create:false queueWorker.maxInflight:1 queueWorker.replicas:1 serviceType:NodePort]
Fixes #8 This has been tested by running this build with basic auth on, then off. Then on, then off. IT was enabled/disabled each time and port forwarding to the gateway gave the correct auth enabled/disabled status depending on how it was deployed. Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Waterdrips
force-pushed
the
waterdrips-fix-basic-auth
branch
from
edb00ce
to
967616f
Compare
|
requested changes implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable switching basic auth on/off on re-running arkade install
Fixes #8
This has been tested by running this build with basic auth on, then off.
Then on, then off. IT was enabled/disabled each time and port forwarding
to the gateway gave the correct auth enabled/disabled status depending on
how it was deployed.
Signed-off-by: Alistair Hey alistair@heyal.co.uk
Motivation and Context
basic auth does not get disabled after enabling it first for openfaas app #8
How Has This Been Tested?
See description
Types of changes
Checklist:
git commit -s