Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Cert Manager app to new style #226

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

yankeexe
Copy link
Contributor

@yankeexe yankeexe commented Oct 16, 2020

Use DefaultInstallOptions pattern for cert-manager installation.

Fixes #225

Signed-off-by: yankeexe yankee.exe@gmail.com

Description

Based on the new pattern of app installation on apps packages,
installation of cert-manager has been changed to utilize the
DefaultInstallOptions method.

Motivation and Context

How Has This Been Tested?

Created a local kind cluster and installed cert-manager.

$ kind create cluster 

Scenario 1

Default Install with no options.

$ ./arkade install cert-manager 

Scenario 2
Install cert-manager in custom namespace.

$ ./arkade install cert-manager -n "cert-test"

Scenario 3
Install user-defined version of cert-manager.

$ ./arkade install cert-manager -v "v0.15.1"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have tested this on arm, or have added code to prevent deployment

Use DefaultInstallOptions pattern for cert-manager installation.

Signed-off-by: yankeexe <yankee.exe@gmail.com>
Copy link
Contributor

@Waterdrips Waterdrips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 9b995ac into alexellis:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Cert Manager app to new style
3 participants