Add secrets API and fix #287 for inlets-operator app #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secrets API allows for re-creation of existing secrets in the cluster when reinstalling apps. This also refactors to a pattern that can be reused in other apps. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com
Description
Add secrets API and fix #287 for inlets-operator app
The secrets API allows for re-creation of existing secrets in
the cluster when reinstalling apps. This also refactors to a
pattern that can be reused in other apps.
Motivation and Context
Fixes #287
Reduces duplication across apps
How Has This Been Tested?
Tested with the app it was added to for taking in a token to DO. First by using /etc/hosts as the key, then providing a real API token file.
Types of changes