Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrades #37

Closed
wants to merge 10 commits into from
Closed

Version upgrades #37

wants to merge 10 commits into from

Conversation

TheYkk
Copy link
Contributor

@TheYkk TheYkk commented Mar 6, 2020

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
@derek derek bot added the new-contributor label Mar 6, 2020
@Waterdrips
Copy link
Contributor

Thanks for the PR

@TheYkk Can you please provide information about how this has been tested as requested in the PR Template?

@TheYkk
Copy link
Contributor Author

TheYkk commented Mar 6, 2020

All upgrades include minor change. Mostly bug fixes.Upgrades does not require any special change.

Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
@derek derek bot added the no-dco label Mar 6, 2020
@derek
Copy link

derek bot commented Mar 6, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
Signed-off-by: Kaan Karakaya <yusufkaan142@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants