Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed k3d binary template for ming os target #590

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

10d9e
Copy link
Contributor

@10d9e 10d9e commented Nov 26, 2021

The k3d binary is missing .exe from the download link. Fixed the binary template.

@derek
Copy link

derek bot commented Nov 26, 2021

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Signed-off-by: Jay Logelin <jay.logelin@gmail.com>
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis
Copy link
Owner

@iwilltry42 I'm trying to gauge if the original PR was incorrect or if this is a breaking change upstream on the K3d project? Can you advise?

https://github.com/alexellis/arkade/blame/8b4a5eeda8c2251d3aaa30db11224975d6adea58/pkg/get/get_test.go#L490

@iwilltry42
Copy link
Contributor

iwilltry42 commented Nov 29, 2021

@alexellis I'd say that the original PR was wrong, as Windows executables were always published with .exe for k3d 🤔
Update: Just checked my PR again and it was definitely my fault back then, sorry! FWIW: we may want to add darwin/arm64 as well now 🤔

@alexellis
Copy link
Owner

@jlogelin thanks again for the PR, but please don't delete the issue or PR template.

@alexellis
Copy link
Owner

No worries @iwilltry42 this happens to all of us. Thanks for confirming.

@alexellis alexellis merged commit f6c1348 into alexellis:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants