-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed k3d binary template for ming os target #590
Conversation
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
Signed-off-by: Jay Logelin <jay.logelin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iwilltry42 I'm trying to gauge if the original PR was incorrect or if this is a breaking change upstream on the K3d project? Can you advise? |
@alexellis I'd say that the original PR was wrong, as Windows executables were always published with .exe for k3d 🤔 |
@jlogelin thanks again for the PR, but please don't delete the issue or PR template. |
No worries @iwilltry42 this happens to all of us. Thanks for confirming. |
The k3d binary is missing
.exe
from the download link. Fixed the binary template.