Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arkade get helmfile for Mac ARM, update owner repo #761

Merged
merged 1 commit into from Sep 2, 2022

Conversation

Jasstkn
Copy link
Contributor

@Jasstkn Jasstkn commented Sep 2, 2022

Signed-off-by: Mariia Kotliarevskaia mariia.kotliarevskaia@gmail.com

Fixes helmfile installation for mac arm64

Description

  • fixes helmfile installation for mac arm64 arch
  • switch to official org for helmfile (https://github.com/helmfile/helmfile)
  • update template to support tar.gz format instead of plain binaries

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

fixes #760

How Has This Been Tested?

./hack/test-tool.sh helmfile
+ go build
+ ./arkade get helmfile --arch arm64 --os darwin --quiet
+ file /Users/mariakot/.arkade/bin/helmfile
/Users/mariakot/.arkade/bin/helmfile: Mach-O 64-bit executable arm64
+ rm /Users/mariakot/.arkade/bin/helmfile
+ ./arkade get helmfile --arch x86_64 --os darwin --quiet
+ file /Users/mariakot/.arkade/bin/helmfile
/Users/mariakot/.arkade/bin/helmfile: Mach-O 64-bit executable x86_64
+ rm /Users/mariakot/.arkade/bin/helmfile
+ ./arkade get helmfile --arch x86_64 --os linux --quiet
+ file /Users/mariakot/.arkade/bin/helmfile
/Users/mariakot/.arkade/bin/helmfile: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=gyj-ZT85t6VbnD6QYDdx/_hHFrFZC6adfyaEx8vsN/o2icmceVllDBHxeh9ihn/G_0zozUJdSnV_-FxyRUJ, stripped
+ rm /Users/mariakot/.arkade/bin/helmfile
+ ./arkade get helmfile --arch arm64 --os linux --quiet
+ file /Users/mariakot/.arkade/bin/helmfile
/Users/mariakot/.arkade/bin/helmfile: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=LL4mt4iONpOLWZeNVx6m/oQ-d6UNOkd6POSVNFcUh/RXnLupWiTy1nP31n8Ct8/STlnkwOCfIqujWP8r8Et, stripped
+ rm /Users/mariakot/.arkade/bin/helmfile
+ ./arkade get helmfile --arch x86_64 --os ming
+ file /Users/mariakot/.arkade/bin/helmfile
/Users/mariakot/.arkade/bin/helmfile: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=LL4mt4iONpOLWZeNVx6m/oQ-d6UNOkd6POSVNFcUh/RXnLupWiTy1nP31n8Ct8/STlnkwOCfIqujWP8r8Et, stripped
+ rm /Users/mariakot/.arkade/bin/helmfile

Are you a GitHub Sponsor yet (Yes/No?)

  • Yes
  • No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Mariia Kotliarevskaia <mariia.kotliarevskaia@gmail.com>
@Jasstkn Jasstkn marked this pull request as ready for review September 2, 2022 15:05
@alexellis alexellis merged commit 8ae2109 into alexellis:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when arkade get helmfile mac m1
2 participants