-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creating a conflicting alias #89
Avoid creating a conflicting alias #89
Conversation
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Do NOT create the alias if there is already a binary with the same name in the path. Signed-off-by: PierreRustOrange <pierre.rust@orange.com>
5c351ae
to
6219d05
Compare
Thanks for the PR. Just need to check that |
Thanks to @mehyedes, it seems that |
Using
That should also work on Git Bash |
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
which is available on git bash and is enough, as we simply need to check if the alias already exist, we don't really care where it is. Signed-off-by: PierreRustOrange <pierre.rust@orange.com>
bc625fe
to
3b117d9
Compare
OK, you're right, |
get.sh
Outdated
ln -s $BINLOCATION/$REPO $BINLOCATION/$ALIAS_NAME | ||
echo "Creating alias '$ALIAS_NAME' for '$REPO'." | ||
if [ $(which $ALIAS_NAME) ]; then | ||
echo "There is already a command '$ALIAS_NAME' in the path, do NOT create alias" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: PierreRustOrange <pierre.rust@orange.com>
Thanks ! Looks fine now 👍 |
LGTM. Tested on Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This fixes issue #88 .
Please note that while I tested it locally, I did not perform an end-to-end test, as the get.sh script downloads directly from github.