Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Add support to riscv64 architecture #1

Closed
wants to merge 1 commit into from
Closed

Add support to riscv64 architecture #1

wants to merge 1 commit into from

Conversation

carlosedp
Copy link
Contributor

Bump libraries to be able to build on riscv64 architecture.

Also required bumping netns dependencies on genuinetools/netns#21

@alexellis
Copy link
Owner

/add label: no-dco

@derek derek bot added the no-dco label Dec 21, 2019
@alexellis
Copy link
Owner

Hi @carlosedp did you not update Gopkg.toml?

@alexellis
Copy link
Owner

Re: netns, I'm not sure that @jessfraz is maintaining the project anymore. @crosbymichael offered to help convert over to go-cni 🙏 - that would remove this dependency too.

@carlosedp as far as you know, does go-cni work on RISCV from when you ported K8s over?

@carlosedp
Copy link
Contributor Author

carlosedp commented Jan 2, 2020

Hi @carlosedp did you not update Gopkg.toml?

I've ran dep ensure -update golang.org/x/sys and it didn't update that file.

All CNI plugins build fine on Risc-V from source. Containerd also builds with CNI interface and Podman runs fine with the CNI plugins from (https://github.com/containernetworking/plugins).

@alexellis
Copy link
Owner

Good to hear CNI works fine. Now I need to do the work to move off netns or someone needs to do a PR for it. I have a sample project showing how to use CNI with containerd

@carlosedp
Copy link
Contributor Author

I'd love to take a look and see if I can do it... if you could point me into the right direction :)

@alexellis
Copy link
Owner

See how I'm using weave and netns in a prerun hook? This example shows what we'd do instead of that.

https://github.com/alexellis/ctrofb/blob/master/cmd/network.go

@carlosedp
Copy link
Contributor Author

Closing as this was addressed by PR #18.

@carlosedp carlosedp closed this Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants