Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Commit

Permalink
Addressed comments.
Browse files Browse the repository at this point in the history
Signed-off-by: dungeonmaster18 <umesh4257@gmail.com>
  • Loading branch information
imumesh18 authored and alexellis committed Jan 19, 2018
1 parent 86a49b1 commit 4f17f48
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 6 additions & 2 deletions Dockerfile
@@ -1,11 +1,15 @@
FROM golang:1.9.2 as build

MAINTAINER alexellis2@gmail.com
LABEL maintainer alexellis2@gmail.com

RUN mkdir -p /go/src/github.com/alexellis/jaas
WORKDIR /go/src/github.com/alexellis/jaas

COPY . .
COPY .git .git
COPY cmd cmd
COPY vendor vendor
COPY version version
COPY main.go .

RUN VERSION=$(git describe --all --exact-match `git rev-parse HEAD` | grep tags | sed 's/tags\///') \
&& GIT_COMMIT=$(git rev-list -1 HEAD) \
Expand Down
6 changes: 1 addition & 5 deletions cmd/version.go
Expand Up @@ -5,7 +5,6 @@ package cmd

import (
"fmt"
"runtime"

"github.com/alexellis/jaas/version"
"github.com/morikuni/aec"
Expand Down Expand Up @@ -40,10 +39,7 @@ func runVersion(cmd *cobra.Command, args []string) {
if shortVersion {
fmt.Println(version.BuildVersion())
} else {
figletColoured := aec.BlueF.Apply(figletStr)
if runtime.GOOS == "windows" {
figletColoured = aec.GreenF.Apply(figletStr)
}
figletColoured := aec.GreenF.Apply(figletStr)
fmt.Printf(figletColoured)
fmt.Printf("Commit: %s\n", version.GitCommit)
fmt.Printf("Version: %s\n", version.BuildVersion())
Expand Down

0 comments on commit 4f17f48

Please sign in to comment.