Allow Pinning of versions for charts #200
Conversation
We have had a case where cert-manager upgraded and we had pinned the CRD to v0.12.0, we installed the latest chart by default so we have 0.12.0 CRD and 0.13.0 chart. This caused issues. We can now optionally pin a helm chart version. Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
| @@ -105,6 +105,7 @@ func MakeInstallCronConnector() *cobra.Command { | |||
| ns, | |||
| outputPath, | |||
| "values.yaml", | |||
| "", | |||
There was a problem hiding this comment.
The empty value is a bit confusing. Should be a named variable I think?
| @@ -107,14 +106,14 @@ schedule workloads to any Kubernetes cluster`, | |||
| } | |||
|
|
|||
| err := helm3Upgrade(outputPath, "crossplane-alpha/crossplane", | |||
| namespace, "values.yaml", map[string]string{}, wait) | |||
| namespace, "values.yaml", "", map[string]string{}) | |||
There was a problem hiding this comment.
I’m a bit worried about updating every app at once. For instance this appears to introduce a bug where wait is being ignored as a parameter.
There was a problem hiding this comment.
wait was not used in the func, so i removed it from the signature and all func calls
There was a problem hiding this comment.
Then it should be used and/or left.
it would be super hacky to try and pass in a version just for 1 chart, they all use the same runner code, and it builds a single string for the command. I actually can't see where I could pass it in to (helm2) (helm3) |
Description
We have had a case where cert-manager upgraded and we
had pinned the CRD to v0.12.0, we installed the
latest chart by default so we have 0.12.0 CRD and
0.13.0 chart. This caused issues.
We can now optionally pin a helm chart version.
Fixes #199
Motivation and Context
Allow Pinning of helm chart versions #199
How Has This Been Tested?
Installed cert-manager (which now has pinned v0.12.0) and it installed that version
Installed OpenFaaS (no pinned version) and it installed latest
Types of changes
Checklist:
git commit -s