Fix: Replace deprecated --no-deploy with --disable causing the installation to fail

[andreazorzetto]

Why do you need this?

k3s installation fails when --no-extras is used because of deprecated --no-deploy
I replaced --no-deploy with --disable

Description

This PR is replacing the deprecated option with the right one

How Has This Been Tested?

Built k3sup and tested with the right option on Ubuntu node

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[brandtkeller]

Came across the same problem and was lead down this same path - question I had is how many previous versions of k3s this tool advertises as actively supporting?

As it relates to these changes - If the goal is as many as possible - then we may need to introduce a check for version for specifying the older --no-deploy as applicable?

[brandtkeller]

@andreazorzetto Do you have any thoughts here for supporting/testing backwards compatibility?

[brandtkeller]

I opened #397 for this same issue - willing to collaborate on getting this issue resolved. Wanting to emphasize a path forward that will get this resolved.

[alexellis]

Closed in 02c7a77