Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing parameters to metric-server. #73

Closed
wants to merge 1 commit into from
Closed

Fix passing parameters to metric-server. #73

wants to merge 1 commit into from

Conversation

jeka
Copy link
Contributor

@jeka jeka commented Oct 28, 2019

Commas in the values of parameters passed to helm via --set must be
backslash-escaped. Otherwise, values are passed as separate parameters.

@derek
Copy link

derek bot commented Oct 28, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Commas in the *values* of parameters passed to helm via --set must be
backslash escaped. Otherwise values are passed as separate parameters.

Signed-off-by: Jetchko Jekov <181360+jeka@users.noreply.github.com>
@alexellis
Copy link
Owner

Please fill out the PR template.

@alexellis
Copy link
Owner

@alexellis alexellis closed this in 0ff2d67 Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants