Add server-user and server-ssh-port options to join command #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
requested changes
Oct 31, 2019
simoncas
force-pushed
the
add-server-user-options
branch
from
8c28d53
to
fa749a9
Compare
|
done |
|
It'd be great if you could run Here's a great guide on how to write commit messages, they usually describe more of the why and how it's been tested than the what (which is in the code) https://chris.beams.io/posts/git-commit/ An example: openfaas/faas@137b63e openfaas/of-watchdog@b0a976b |
It often happens that the server and agents do not share the same configuration. The two new options (server-user and server-ssh-port) allow you to specify the username and the ssh port of the server to the join command. Signed-off-by: Simon Castella <castella.simon@gmail.com>
simoncas
force-pushed
the
add-server-user-options
branch
3 times, most recently
from
da8b5f2
to
4d95a92
Compare
|
Could you do a test with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon Castella castella.simon@gmail.com
Add --server-user and --server-ssh-port options to the join command. Those are handy options to setup a cluster when server and agents are configured differently.
Description
Add --server-user and --server-ssh-port options to the join command.
The default behavior is to use the values respectively specified by the --ssh-port and the --user commands.
Motivation and Context
Implements the solution discussed here #34
How Has This Been Tested?
This has been tested with 2 VMs which have been setup using multipass:
Then I create the cluster using the following commands:
Types of changes
Checklist:
git commit -s