Update manifest to IfNotPresent

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis · Nov 4, 2020 · ecb6ab9 · ecb6ab9
1 parent 00139d6
commit ecb6ab9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/.github/workflows/ci-only.yaml b/.github/workflows/ci-only.yaml
@@ -30,24 +30,20 @@ jobs:
           outputs: "type=docker,push=false"
           platforms: linux/amd64
           tags: ghcr.io/alexellis/registry-creds:${{ github.sha }}
-      - name: Image digest
-        run: echo ghcr.io/alexellis/registry-creds:${{ github.sha }}
       - name: Image digest 2
         run: echo ${{ steps.local_build.outputs.digest }}
       - name: Setup Kubernetes
         uses: engineerd/setup-kind@v0.4.0
         with:
           version: "v0.9.0"
           image: kindest/node:v1.18.8
-      - name: Show images
-        run: docker images
       - name: Load test image
-        run: kind load --loglevel trace docker-image ghcr.io/alexellis/registry-creds:${{ github.sha }}
-      - name: Apply CRD
+        run: kind load --loglevel trace docker-image ${{ steps.local_build.outputs.digest }}
+      - name: Apply manifests
         run: |
-          export TAG=${{ github.sha }}
           TAG=${{ github.sha }} make shrinkwrap
+          cat ./manifest.yaml | grep ghcr
           kubectl apply -f ./manifest.yaml
       - name: Check deployment
-        run: 
-          kubectl rollout status -n registry-creds-system deploy/registry-creds-registry-creds-controller --timeout=2m || kubectl describe -n registry-creds-system deploy/registry-creds-registry-creds-controller
+        run:
+          kubectl rollout status -n registry-creds-system deploy/registry-creds-registry-creds-controller --timeout=2m || kubectl describe -n registry-creds-system deploy/registry-creds-registry-creds-controller && kubectl get events -n registry-creds-system
diff --git a/config/controller/controller.yaml b/config/controller/controller.yaml
@@ -29,6 +29,7 @@ spec:
         - --enable-leader-election
         image: ghcr.io/alexellis/registry-creds-controller:0.2.0
         name: controller
+        imagePullPolicy: IfNotPresent
         resources:
           limits:
             cpu: 100m