Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support additional ServiceAccounts beyond the default account in each namespace #10

Merged
merged 1 commit into from Nov 4, 2020

Conversation

developer-guy
Copy link
Contributor

@developer-guy developer-guy commented Nov 3, 2020

Description

Support additional ServiceAccounts beyond the default account in each namespace

Checklist:

  • Fixes issue: #
  • I waited for approval before creating this PR

How Has This Been Tested?

$ eval $(minikube docker-env)
$ make docker-build
$ make install deploy
$ arkade install ingress-nginx
$ arkade install cert-manager

$ kubectl create secret docker-registry registry-creds-secret \
  --namespace kube-system \
  --docker-username=$USERNAME \
  --docker-password=$PW \
  --docker-email=$EMAIL

$ kubectl create serviceaccount demo-sa 

$  echo -n "apiVersion: ops.alexellis.io/v1
kind: ClusterPullSecret
metadata:
  name: dockerhub
spec:
  secretRef:
    name: registry-creds-secret
    namespace: kube-system" | k apply -f -

$ kubectl get serviceaccounts default -oyaml 
$ kubectl get serviceaccounts demo-sa -oyaml


Screen Shot 2020-11-04 at 00 53 49

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

Dockerfile Outdated
@@ -20,13 +20,13 @@ COPY controllers/ controllers/

# Build
RUN CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
GO111MODULE=on go build -ldflags="-w -s" -a -o /usr/bin/controller
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. This should be controller everywhere. Can you update it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, done.

@@ -67,7 +67,7 @@ Todo:
Apply the YAML for the manifest.

```bash
kubectl apply -f https://raw.githubusercontent.com/alexellis/registry-creds/master/mainfest.yaml
kubectl apply -f https://raw.githubusercontent.com/alexellis/registry-creds/master/manifest.yaml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@alexellis
Copy link
Owner

@developer-guy please can you detail the testing that you did?

I saw that the "How has this been tested" section was removed from the PR template.

@alexellis
Copy link
Owner

Please add missing fields from https://raw.githubusercontent.com/alexellis/registry-creds/master/.github/pull_request_template.md

…t in each namespace

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants