New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Support additional ServiceAccounts beyond the default account in each namespace #10
Conversation
56c6e47
to
4fdf736
Compare
Dockerfile
Outdated
@@ -20,13 +20,13 @@ COPY controllers/ controllers/ | |||
|
|||
# Build | |||
RUN CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} \ | |||
GO111MODULE=on go build -ldflags="-w -s" -a -o /usr/bin/controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake. This should be controller
everywhere. Can you update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, done.
@@ -67,7 +67,7 @@ Todo: | |||
Apply the YAML for the manifest. | |||
|
|||
```bash | |||
kubectl apply -f https://raw.githubusercontent.com/alexellis/registry-creds/master/mainfest.yaml | |||
kubectl apply -f https://raw.githubusercontent.com/alexellis/registry-creds/master/manifest.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
@developer-guy please can you detail the testing that you did? I saw that the "How has this been tested" section was removed from the PR template. |
Please add missing fields from https://raw.githubusercontent.com/alexellis/registry-creds/master/.github/pull_request_template.md |
…t in each namespace Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Description
Support additional ServiceAccounts beyond the default account in each namespace
Checklist:
How Has This Been Tested?
Checklist:
I have:
git commit -s