Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize repository #53

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Reorganize repository #53

merged 3 commits into from
Mar 22, 2024

Conversation

alexey-zakharenkov
Copy link
Owner

  • A mess of validator code and related tools is organized into somewhat logical directory structure.
  • Huge subway_structure.py module is split into several smaller modules.
  • Use python virtual environment.

@AMStrakhov
Copy link
Collaborator

AMStrakhov commented Mar 14, 2024

Предлагаю преобразовать все директории с python-скриптами в модули, добавив __init__.py. В __init__.py прописать __all__ = ["Список объектов, которые могут торчать наружу AKA интерфейс"].

Это даст:

  1. В IDE будет сразу видно, где лежат скрипты
  2. Упростится импорт
  3. Будет более выраженная инкапсуляция

@alexey-zakharenkov alexey-zakharenkov force-pushed the reorganize-repository branch 2 times, most recently from f82ee1d to d2259c6 Compare March 20, 2024 16:08
README.md Outdated
@@ -1,7 +1,7 @@
# Subway Preprocessor

Here you see a list of scripts that can be used for preprocessing all the metro
systems in the world from OpenStreetMap. `subway_structure.py` produces
systems in the world from OpenStreetMap. `scripts/subway_structure.py` produces
Copy link
Collaborator

@AlexanderSilaev AlexanderSilaev Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
systems in the world from OpenStreetMap. `scripts/subway_structure.py` produces
systems in the world from OpenStreetMap. `subways` package produces

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+

@alexey-zakharenkov alexey-zakharenkov merged commit 6a4c2a2 into master Mar 22, 2024
1 check passed
@alexey-zakharenkov alexey-zakharenkov deleted the reorganize-repository branch March 22, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants