Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce package size by removing semi #28

Merged
merged 2 commits into from Oct 4, 2021
Merged

Reduce package size by removing semi #28

merged 2 commits into from Oct 4, 2021

Conversation

ai
Copy link
Contributor

@ai ai commented Oct 4, 2021

Just a small fun optimization

5.8 KB → 5.7 KB

@alexeyraspopov
Copy link
Owner

I'm all for removing semicolons, since prettier does all the job.

Regarding package.json changes: I've been trying to do the same, but there is a caveat: NPM does JSON.stringify(manifest, null, 2) whenever you use it to manage dependencies. Long time ago there was a clash between Prettier and NPM because of this. Nowadays Prettier just avoids doing anything unusual to package.json and this is why I also intentionally added 2 spaces formatting for the file in .editorconfig.

@ai
Copy link
Contributor Author

ai commented Oct 4, 2021

Regarding package.json changes: I've been trying to do the same, but there is a caveat: NPM does JSON.stringify(manifest, null, 2) whenever you use it to manage dependencies. Long time ago there was a clash between Prettier and NPM because of this. Nowadays Prettier just avoids doing anything unusual to package.json and this is why I also intentionally added 2 spaces formatting for the file in .editorconfig.

Oops. The package.json change was made by accident.

Fixed.

@alexeyraspopov alexeyraspopov merged commit 8c663b7 into alexeyraspopov:main Oct 4, 2021
@alexeyraspopov alexeyraspopov mentioned this pull request Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants