Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on titanic example #123

Closed
eddelbuettel opened this issue Mar 3, 2022 · 7 comments
Closed

Fails on titanic example #123

eddelbuettel opened this issue Mar 3, 2022 · 7 comments

Comments

@eddelbuettel
Copy link

Something is off here. Just installed 0.0.13 as a .deb yet:

edd@rob:/tmp$ wget https://raw.githubusercontent.com/datasciencedojo/datasets/master/titanic.csv
--2022-03-03 07:42:13--  https://raw.githubusercontent.com/datasciencedojo/datasets/master/titanic.csv
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 2606:50c0:8002::154, 2606:50c0:8000::154, 2606:50c0:8001::154, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|2606:50c0:8002::154|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 60302 (59K) [text/plain]
Saving to: ‘titanic.csv’

titanic.csv                100%[=====================================>]  58.89K  --.-KB/s    in 0.002s  

2022-03-03 07:42:13 (26.0 MB/s) - ‘titanic.csv’ saved [60302/60302]

edd@rob:/tmp$ head titanic.csv 
PassengerId,Survived,Pclass,Name,Sex,Age,SibSp,Parch,Ticket,Fare,Cabin,Embarked
1,0,3,"Braund, Mr. Owen Harris",male,22,1,0,A/5 21171,7.25,,S
2,1,1,"Cumings, Mrs. John Bradley (Florence Briggs Thayer)",female,38,1,0,PC 17599,71.2833,C85,C
3,1,3,"Heikkinen, Miss. Laina",female,26,0,0,STON/O2. 3101282,7.925,,S
4,1,1,"Futrelle, Mrs. Jacques Heath (Lily May Peel)",female,35,1,0,113803,53.1,C123,S
5,0,3,"Allen, Mr. William Henry",male,35,0,0,373450,8.05,,S
6,0,3,"Moran, Mr. James",male,,0,0,330877,8.4583,,Q
7,0,1,"McCarthy, Mr. Timothy J",male,54,0,0,17463,51.8625,E46,S
8,0,3,"Palsson, Master. Gosta Leonard",male,2,3,1,349909,21.075,,S
9,1,3,"Johnson, Mrs. Oscar W (Elisabeth Vilhelmina Berg)",female,27,0,2,347742,11.1333,,S
edd@rob:/tmp$ 
edd@rob:/tmp$ tidy-viewer --version
tv 0.0.13
edd@rob:/tmp$ tidy-viewer titanic.csv 
error: Found argument 'titanic.csv' which wasn't expected, or isn't valid in this context

USAGE:
    tidy-viewer [FLAGS] [OPTIONS]

For more information try --help
edd@rob:/tmp$ tidy-viewer ./titanic.csv 
error: Found argument './titanic.csv' which wasn't expected, or isn't valid in this context

USAGE:
    tidy-viewer [FLAGS] [OPTIONS]

For more information try --help
edd@rob:/tmp$ 
@eddelbuettel
Copy link
Author

eddelbuettel commented Mar 3, 2022

Fixed now with 1.4.3.

All good. Had an inkling something possible easier with less and bat -- I had set an env var for 'colored' less for a long time but your README is correct in needing the arguments when piping. Which is odd as some tty programs preserve color for bat. (I.e. for me git diff is in color per a git config var, git diff | bat also works). I know too little about terminal escape sequences to help.

@eddelbuettel
Copy link
Author

eddelbuettel commented Mar 3, 2022

I saw the open issue with the rpm -- there is an old-but-trusted tool called alien you could use to turn the generated .deb into a .rpm.

Also, the path here is slightly wrong for the README:

edd@rob:~$ dpkg -L tidy-viewer 
/usr
/usr/share
/usr/share/doc
/usr/share/doc/tidy-viewer
/usr/share/doc/tidy-viewer/copyright
/usr/bin
/usr/bin/tidy-viewer
/usr/share/doc/cargo-deb
/usr/share/doc/cargo-deb/README
edd@rob:~$ 

@alexhallam
Copy link
Owner

Thanks Dirk. Also, I feel honored you are looking at my package. I have been following your work for a long time.

What would you suggest for colors. If you look at my issues you will see I am still playing around with this #120 #119.

As far as deb goes. I am still uploading these releases manually. I just need to get github actions to do it for me. Sometimes I get my wires crossed and upload something incorrect. #122

@eddelbuettel
Copy link
Author

Well I live on the command-line (see littler which you could add to list of related packages: https://github.com/eddelbuettel/littler, also on CRAN) and use command-line enhancers like bat. I have some things like visidata installed too but will admit I use them little to none so this fits an interest.

@eddelbuettel
Copy link
Author

And colors are hard. I have colorout installed here which does the job for me, but I also use data.table more so ...

https://github.com/jalvesaq/colorout

@alexhallam
Copy link
Owner

Well I live on the command-line (see littler which you could add to list of related packages: https://github.com/eddelbuettel/littler, also on CRAN) and use command-line enhancers like bat. I have some things like visidata installed too but will admit I use them little to none so this fits an interest.

Ah yes, littler. I have used that many times. Really great package.

@eddelbuettel
Copy link
Author

Thanks for the quick chat, and an updated .deb. I think we can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants