-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add light mode #135
Comments
Not a problem. I can add a light solarized theme. Since you are asking I will let you tell me what number you want it associated with. Also, you may already know this but you can define any color scheme you want in a config. |
Thanks! Maybe it can be (6)solarized_light, assuming that the current highest number is (5)uncolor.
I had tried to define a Solarized Light color scheme based on the palette shown on Wikipedia:
I threw these into |
Got it. The problem is probably due to the fact the every key and value must be defined in the config to make it work. I have since learned how to make the config more flexible, but have not implemented the change.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: John F. Wu ***@***.***>
Sent: Wednesday, July 6, 2022 3:06:20 PM
To: alexhallam/tv ***@***.***>
Cc: Alex Hallam ***@***.***>; Comment ***@***.***>
Subject: Re: [alexhallam/tv] Add light mode (Issue #135)
Not a problem. I can add a light solarized theme. Since you are asking I will let you tell me what number you want it associated with.
Thanks! Maybe it can be (6)solarized_light, assuming that the current highest number is (5)uncolor.
Also, you may already know this but you can define any color scheme you want in a config.
I had tried to define a Solarized Light color scheme based on the palette shown on Wikipedia<https://en.wikipedia.org/wiki/Solarized#Colors>:
meta_color = [108, 113, 193]
header_color = [88, 110, 117]
std_color = [131, 148, 150]
na_color = [220, 50, 47]
neg_num_color = [42, 161, 152]
I threw these into $HOME/Library/Application\ Support/tv.toml but that didn't seem to work for me. (Note that I didn't rebuild tv so perhaps that was the issue?)
—
Reply to this email directly, view it on GitHub<#135 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACG6GBLTWZXLBTSO42CIQPLVSXKKZANCNFSM522W2RCA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
I will add those colors to ship with tv! |
Thanks for the update. It looks great to me! |
I noticed that none of the built-in color palettes work well with my light mode terminal (I use solarized light). It would be nice to add in at least one light mode palette!
The text was updated successfully, but these errors were encountered: