[WIP] Make adding new Policy Models flexible #327
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engmubarak48
requested review from
michalkoziarski,
josephdviviano and
alexhernandezgarcia
josephdviviano
approved these changes
Jun 18, 2024
|
|
||
|
|
||
| class MLPPolicy(ModelBase): | ||
| def __init__(self, config, env, device, float_precision, base=None): |
There was a problem hiding this comment.
I notice these inputs are never checked anywhere -- I'm wondering if some assertions, typechecks, etc. would be helpful either here or in the base class.
There was a problem hiding this comment.
Hi @josephdviviano thanks, I just started.. I will let you know when it is ready for review :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293
This PR tries to make adding new function approximations (policy models) as flexible as possible.
base.pyfile to dynamically import and instantiate policy models based on configurationModelBaseclass