Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Make adding new Policy Models flexible #327

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

[WIP] Make adding new Policy Models flexible #327

wants to merge 31 commits into from

Commits on Jun 18, 2024

  1. initial commit: split the base policy and the architectures

    @engmubarak48
    engmubarak48 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    98e4d7e View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. ignore git logs

    @engmubarak48
    engmubarak48 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1388756 View commit details
    Browse the repository at this point in the history

  2. refactor base policy class and move models into differrent file

    @engmubarak48
    engmubarak48 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7c8a517 View commit details
    Browse the repository at this point in the history

  3. handle when config none gracefully

    @engmubarak48
    engmubarak48 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    4ecd865 View commit details
    Browse the repository at this point in the history

  4. black formatting

    @engmubarak48
    engmubarak48 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d50aeea View commit details
    Browse the repository at this point in the history

  5. further formatting with isort

    @engmubarak48
    engmubarak48 committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1508e4b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. formatting black + isort

    @engmubarak48
    engmubarak48 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9cdf18e View commit details
    Browse the repository at this point in the history

  2. added flatten flag and device movement handling

    @engmubarak48
    engmubarak48 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8af7f82 View commit details
    Browse the repository at this point in the history

  3. bug fix: use .cpu() before .numpy()

    @engmubarak48
    engmubarak48 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9474150 View commit details
    Browse the repository at this point in the history

  4. added cnn policy, and flatten flag should be set to false when using … 

    …cnn policy
    @engmubarak48
    engmubarak48 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    83a4904 View commit details
    Browse the repository at this point in the history

  5. black formatting

    @engmubarak48
    engmubarak48 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e254cf2 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. smaller cnn config like kernel size etc

    @engmubarak48
    engmubarak48 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d30c3f2 View commit details
    Browse the repository at this point in the history

  2. minor refactor on parse_config

    @engmubarak48
    engmubarak48 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2ac9af5 View commit details
    Browse the repository at this point in the history

  3. move self.is_model to instantiate and add super().parse_config(config… 

    …) in the parse_config
    @engmubarak48
    engmubarak48 committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7e02200 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Add docstring and typing to __init__ of policy base.

    @alexhernandezgarcia
    alexhernandezgarcia committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e6a14ef View commit details
    Browse the repository at this point in the history

  2. Use kwargs instead of listing parameters explicitly

    @alexhernandezgarcia
    alexhernandezgarcia committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    57b0b13 View commit details
    Browse the repository at this point in the history

  3. Policy MLP: docstring and typing.

    @alexhernandezgarcia
    alexhernandezgarcia committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    178a08e View commit details
    Browse the repository at this point in the history

  4. Get rid of parse_config and include its content in __init__

    @alexhernandezgarcia
    alexhernandezgarcia committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ace8a28 View commit details
    Browse the repository at this point in the history

  5. Combine instantiate and make_* into a single method make_model()

    @alexhernandezgarcia
    alexhernandezgarcia committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8e6f03d View commit details
    Browse the repository at this point in the history

  6. Missing import

    @alexhernandezgarcia
    alexhernandezgarcia committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    774c411 View commit details
    Browse the repository at this point in the history

  7. Fix config issue by implementing _get_config()

    @alexhernandezgarcia
    alexhernandezgarcia committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9520315 View commit details
    Browse the repository at this point in the history

  8. Docstring for base argument

    @alexhernandezgarcia
    alexhernandezgarcia committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    910a948 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge pull request #335 from alexhernandezgarcia/ahg/293-flexible-pol… 

    …icy-definition

[WIP, Policy] Docstring and refactoring on top of PR 327
    @josephdviviano
    josephdviviano authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c9ec03f View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. remove env from the cnn policy

    @engmubarak48
    engmubarak48 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9fa9381 View commit details
    Browse the repository at this point in the history

  2. init the cnn env's height and width in the policy

    @engmubarak48
    engmubarak48 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2bf438a View commit details
    Browse the repository at this point in the history

  3. add mlp to device

    @engmubarak48
    engmubarak48 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9395e61 View commit details
    Browse the repository at this point in the history

  4. formatting

    @engmubarak48
    engmubarak48 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    595db80 View commit details
    Browse the repository at this point in the history

  5. debug: add to print environment information when running GitHub Actio… 

    …ns workflow
    @engmubarak48
    engmubarak48 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6797bcc View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add the specific versions of pymatgen and spglib

    @engmubarak48
    engmubarak48 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    95258a0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 293-flexible-policy-definition

    @engmubarak48
    engmubarak48 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    61f1e1d View commit details
    Browse the repository at this point in the history

  3. revert version downgrade of pymatgen

    @engmubarak48
    engmubarak48 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b7f33d8 View commit details
    Browse the repository at this point in the history