Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dismissing viewController with dismiss(animated:completion:) method #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

i5glu
Copy link

@i5glu i5glu commented Aug 2, 2019

I use your gallery in my app, it's very nice, but if found issue:
When you try to dismiss photoViewer calling dismiss(animated:completion:) from another class, app freezes. It's because transitionController has flag "forceNonInteractiveDismissal" set to false and "interactionControllerForDismissal" return dismissal animator, while it should return nil to perform non interactive dismissal correctly.

I renamed flag "forceNonInteractiveDismissal" to "forceInteractiveDismissal" and changed logic, so interaction dismissal begins with gesture recognizer, and default dismissal is now non interactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant