Version 5.0 #189
Version 5.0 #189
Conversation
* Fix the background view origin when presenting When presenting over a ViewController (the “from” VC), if that ViewController is not at the screen’s origin, the background view will not appear at the correct position above it. This fixes the problem by setting the background view’s frame to the “from” VC’s view’s frame **converted into the coordinate system of the container view.** * add PR to CHANGELOG
As outlined by version 5 manifest.
|
How come is this even tagged as release candidate?
|
Thanks for your constructive feedback! As you can see, @ollitapa already fixed it in |
|
Thanks for maintaining this repo! |
|
Hey Alex - Thanks for getting SPM working! I'd love to be able to move this dependency off Carthage and onto SPM. Any chance you could tag RC 2 today? |
|
@aaronbrethorst Done! |
|
Thank you! |
* Fix the background view origin when presenting (#183) * Fix the background view origin when presenting When presenting over a ViewController (the “from” VC), if that ViewController is not at the screen’s origin, the background view will not appear at the correct position above it. This fixes the problem by setting the background view’s frame to the “from” VC’s view’s frame **converted into the coordinate system of the container view.** * add PR to CHANGELOG * Add support for Swift Package Manager (#158) (#178) * Update project to support Swift Package Manager * Update CHANGELOG * Only create one library * Reorganize Swift project to better support SPM * Update README * Clean up files * Update BLTNItem.swift * Rename master to main * Update Podscpec * Require iOS 11 * Update CHANGELOG * Update podspec * SPM also to require iOS 11 (#190) As outlined by version 5 manifest. Co-authored-by: Ken Zinn <ken.zinn@nonzerosolutions.com> Co-authored-by: Olli Tapaninen <ollitapa@gmail.com> Co-authored-by: Ken Zinn <ken.zinn@nonzerosolutions.com> Co-authored-by: Olli Tapaninen <ollitapa@gmail.com>
|
Has anyone tested this? It does not seem like it works properly (at least not on Xcode 12.1). Package does not compile. |
|
I've been using the package and it works fine for me. I think the error you are seeing is because you have included the SPM module in two or more Xcode style ".framework" modules. This is a "known" limitation in Xcode and to work around it, you need to make an umbrella ".framework" for your common SPM modules and import that in both of your own modules. |
|
@ollitapa It is in fact a framework but all other SPM packages in the framework just work perfectly.
|
|
Hmm, maybe you have some Carthage/CocoaPods leftovers? Some copy-frameworks step? At least my umbrella framework builds fine. |
In this version, we add support for the Swift Package Manager. To make these changes possible, we decided to make the following breaking changes:
We are planning to release this version on October 25, 2020. During the next month, please reply to this PR with feedback about any bugs or request.
To use the release candidate version, please use the following tag in your package manager:
5.0.0-rc.2