Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

feat(log_stream): support JSONOBJECT format #445

Merged

Conversation

mbelang
Copy link
Contributor

@mbelang mbelang commented Sep 10, 2021

Proposed Changes

  • Add support for JSONOBJECT form for http log stream. This feature is supported in the UI and should be in terraform provider.

crop

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@mbelang mbelang changed the title feat(log_stream):support JSONOBJECT format feat(log_stream): support JSONOBJECT format Sep 10, 2021
alekc added a commit to alekc/terraform-provider-auth0 that referenced this pull request Sep 19, 2021
alekc added a commit to alekc/terraform-provider-auth0 that referenced this pull request Sep 19, 2021
@mbelang
Copy link
Contributor Author

mbelang commented Sep 22, 2021

@alekc I see you are taking my PR in your provider. There is something I do not understand. Is this provider deprecated or what?

@alekc
Copy link

alekc commented Sep 22, 2021

@mbelang tbh I do not know.

The current release pace on this repo was not fast enough for our needs (i.e. there are 2 severe bugs which can affect your pipelines, 1 severe enough to prevent you from running plan at all, and there were PR fixing them several month old not reviewed), so I ended up forking the repo, fixing bugs, and maintaining it by myself.

I've merged some PR from this one into mine (since I could not keep the author I referenced them in the commits/PR to give the proper credit), thats why you see what you see.

@mbelang
Copy link
Contributor Author

mbelang commented Nov 24, 2021

@alexkappa any chance that one can go in?

Copy link
Collaborator

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible PR, can confirm that JSONOBJECT is a supported value with the Auth0 API. I believe your test isn't actually testing the new functionality due to a copy-paste mistake, so I can correct and re-run. May also add an example or adjust documentation too.

auth0/resource_auth0_log_stream_test.go Outdated Show resolved Hide resolved
@willvedd willvedd merged commit fc42e5e into alexkappa:master Jan 25, 2022
@mbelang mbelang deleted the feat/log-stream-support-json-object branch January 25, 2022 17:56
@sergiught sergiught mentioned this pull request Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants