Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecallSuite tests are extremely slow in Github Actions #400

Closed
1 task done
alexklibisz opened this issue Jul 23, 2022 · 2 comments · Fixed by #408
Closed
1 task done

RecallSuite tests are extremely slow in Github Actions #400

alexklibisz opened this issue Jul 23, 2022 · 2 comments · Fixed by #408
Labels
bug Something isn't working

Comments

@alexklibisz
Copy link
Owner

Support guidelines

Background

Running the RecallSuite in Github Actions to merge an unrelated PR. Examples: #399 , #398 , #397 .

Bug

The RecallSuite is taking > 30 minutes to run. In comparison, the entire test suite takes ~10 minutes to run locally on a 2018 i7 mac mini.

Elastiknn Version

7.17.5.0

Platform

Github Actions

Steps to reproduce

  1. Make a PR.
  2. Watch the CI/test-jvm job run.

Additional info

I can't think of any code changes that would have caused this. It seems like a Github problem.
@alexklibisz alexklibisz added the bug Something isn't working label Jul 23, 2022
alexklibisz added a commit that referenced this issue Sep 15, 2022
@alexklibisz
#400: Set timeouts on github workflow jobs
c8c4759
@alexklibisz alexklibisz mentioned this issue Sep 15, 2022
Merged
alexklibisz added a commit that referenced this issue Sep 15, 2022
@alexklibisz
#400: Set timeouts on github workflow jobs (#408)
84b2e0a
@alexklibisz alexklibisz mentioned this issue Sep 25, 2022
Merged
@alexklibisz alexklibisz reopened this Sep 25, 2022
@alexklibisz
Copy link
Owner Author

I added DoNotDiscover to the RecallSuite in #431

Need to figure out what's up and revert that change.

@alexklibisz alexklibisz mentioned this issue Sep 26, 2022
Merged
@alexklibisz
Copy link
Owner Author

This seems to have been fixed in #434 , primarily by limiting the resources made available to SBT and the Elasticsearch containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#400: Set timeouts on github workflow jobs alexklibisz/elastiknn
1 participant
@alexklibisz