-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Use Github Actions caching instead of SBT caching #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Changes
target
directories. More details below.@DoNotDiscover
on the RecallSuite, as it's mis-behaving again (RecallSuite tests are extremely slow in Github Actions #400). It passes fine locally, so it seems like some sort of throttling or contention in Github actions.Some more details on caching:
There was a subtle problem with SBT's caching: the
succeeded_tests
file used by the testQuick command stores the timestamp at which each test suite last succeeded. The next time you runtestQuick
, if the test suite has been recompiled after that stored timestamp, the test will run-again. I thought that usingpullRemoteCache
would mean that the tests are not recompiled. That turns out to not be exactly the case. The test is compiled extremely quickly (<= 1s for full compilation), but it's nevertheless re-compiled. That means it needs to be executed, despite having already passed according to thesucceeded_tests
file.It turns out that caching each of the
target
directories solves this problem, and it's probably simpler overall, anyways. The target directory contains the old compilation state and thesucceeded_tests
file. So if a test suite hasn't changed, it genuinely just won't be recompiled, and so the test suite won't re-run.The caching action is documented here: Caching dependencies to speedup workflows
Testing and Validation