Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a situation where asynchronous functions added to a open groupie.chain are called excessively.
The "add()" method was calling "callNext()" if the group "hasMore()" functions to process. Since this was always true after adding a new function, "callNext()" was executed. In the example below, the first function has not returned yet (incrementing 'pos'), so it is called 3 more times.
I'm thinking the logic within the "add()" method is trying to check if it is processing anything at the current time. If it is processing something, "callNext()" will be called when the processing function is done, otherwise start the new function with "callNext()".
All of this only comes into play when it's an open groupie.chain and a function is asynchronous.
Example code:
Output with current groupie:
Output with pull request:
Best,
Barret