Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow evaluation of lists/tuples/sets/dicts #6

Merged
merged 4 commits into from Jan 29, 2021

Conversation

pwwang
Copy link
Contributor

@pwwang pwwang commented Jan 28, 2021

#5

tests/test_core.py Outdated Show resolved Hide resolved
@alexmojaki
Copy link
Owner

Thanks for the PR! The tests are good, the implementation is a good start, but it has a decent amount of duplicated logic and duplicated computation. Can you refactor it a bit?

@pwwang
Copy link
Contributor Author

pwwang commented Jan 28, 2021

Are you referring to the Evaluator._handle method / Evaluator class or the whole package?

@alexmojaki
Copy link
Owner

The code you added to _handle, considered in isolation

@pwwang
Copy link
Contributor Author

pwwang commented Jan 28, 2021

I am actually not quite sure if this is what you wanted it to be...

@alexmojaki
Copy link
Owner

That's the kind of thing I meant, yes. Looks like travis is being weird, will check on this again later.

@pwwang
Copy link
Contributor Author

pwwang commented Jan 28, 2021

This isn't the first time that travis gets stuck. You probably want to switch to GH actions ...

@alexmojaki
Copy link
Owner

Indeed, I recently did that for the first time with executing because Travis is going through some changes. But it's still enough of a pain that I'm going to procrastinate it. Looks like travis woke up in the end. Thanks for the PR!

@alexmojaki alexmojaki merged commit 0e5d450 into alexmojaki:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants