Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show while auto-completion #12

Closed
seagle0128 opened this issue Mar 14, 2019 · 7 comments
Closed

Don't show while auto-completion #12

seagle0128 opened this issue Mar 14, 2019 · 7 comments

Comments

@seagle0128
Copy link

seagle0128 commented Mar 14, 2019

Thanks for the great package!

I have an issue while input with company. When auto-completion popup, the flycheck-posframe still popups, which overrides the company prompts. I think it should not display while auto-completion popups.

image

@alexmurray
Copy link
Owner

I can't reproduce this - it looks like you are using company-box - but even with that enabled I don't see this. Can you provide any more details how to reproduce it?

@seagle0128
Copy link
Author

seagle0128 commented Mar 27, 2019

Thanks for the reply!

I think it's not related to company-box. I was trying to reproduce with vanilla Emacs, and found it occurred with python-mode, flycheck-mode, company-mode and lsp-mode. Attached the recording below.

emacs

alexmurray added a commit that referenced this issue Mar 27, 2019
This is to allow to solve issues like #12 in a generic way
@alexmurray
Copy link
Owner

Thanks - ok I have managed to reproduce it... I have just added a generic interface d1591cf which should allow you to relatively easily avoid this - with the latest git master you should be able to do the following:

(add-to-list 'flycheck-posframe-inhibit-functions #'(lambda () company-backend)

Which will inhibit display of flycheck-posframe whenever company-backend is non-nil (which it is when company completion is active from what I can see).

Let me know what you think.

@seagle0128
Copy link
Author

Perfect! It does work for me.

Suggest to make it as default value: (lambda () (bound-and-true-p company-backend)).

seagle0128 added a commit to seagle0128/.emacs.d that referenced this issue Mar 27, 2019
@sethen
Copy link

sethen commented Jul 10, 2023

@alexmurray Any chance you can help me to do the same thing for corfu? lol

@sethen
Copy link

sethen commented Jul 10, 2023

@alexmurray Actually with some playing I found out that corfu--candidates variable did the trick. Same thing as company-backends but corfu specific.

@alexmurray
Copy link
Owner

@sethen how about the following (untested):

(add-to-list 'flycheck-posframe-inhibit-functions #'(lambda () (and (bound-and-true-p corfu-mode) (bound-and-true-p completion-in-region-mode))))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants