Fix retry button issues #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments passed to retryDownload by the retry button do not match what the function actually expects. This causes downloads to break if a custom folder is set and also causes some settings like format and custom name prefix to be ignored.
Closed
|
Thanks @JLyne !! |
|
@JLyne Thanks for the patch i've applied it. However there seems to be an edge case where if the video failed to download due to many reason it shows weird behavior in the completed list. See attached photo.
The text in the options side seems to be the same place as the download button supposed to be. |
|
Example from correct behavior for completed download vs failed download
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments passed to
retryDownloadby the retry button do not match what the function actually expects. This causes a few issues:This PR fixes these problems by passing the entire download object to
retryDownload, which now populates everything correctly. TheDownloadinterface was also updated to include all the fields actually sent by the server.Fixes #233, #262