Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop with ./jarvis.sh -x "" #583

Closed
QuentinCG opened this issue May 4, 2017 · 3 comments
Closed

Infinite loop with ./jarvis.sh -x "" #583

QuentinCG opened this issue May 4, 2017 · 3 comments
Assignees
Labels

Comments

@QuentinCG
Copy link

Description

Sending an empty request to Jarvis will create an infinite loop of fail...
This has impact on all plugins using ./jarvis.sh -x.

Maybe plugins should check if the command is empty and then not send it, but a check in jarvis should be added too.

If I have time, I'll check this bug myself ;)

Logs

pi@raspberrypi:~/jarvis $ ./jarvis.sh -x ""
./jarvis.sh: ligne 174: recorders//main.sh: Aucun fichier ou dossier de ce type
./jarvis.sh: ligne 175: stt_engines/false/main.sh: Aucun fichier ou dossier de ce type
./jarvis.sh: ligne 176: stt_engines//main.sh: Aucun fichier ou dossier de ce type
maitre: ./jarvis.sh: ligne 404: _STT : commande introuvable
./jarvis.sh: ligne 404: _STT : commande introuvable
./jarvis.sh: ligne 404: _STT : commande introuvable

jarvis: Waiting to hear 'jarvis'
maitre: ./jarvis.sh: ligne 406: false_STT : commande introuvable
./jarvis.sh: ligne 406: false_STT : commande introuvable
./jarvis.sh: ligne 406: false_STT : commande introuvable

jarvis: Waiting to hear 'jarvis'
maitre: ./jarvis.sh: ligne 406: false_STT : commande introuvable
./jarvis.sh: ligne 406: false_STT : commande introuvable
./jarvis.sh: ligne 406: false_STT : commande introuvable
@alexylem
Copy link
Owner

alexylem commented May 4, 2017

I have a slightly different behavior:

$> ./jarvis.sh -b # jarvis needs to run
$> ./jarvis.sh -x ""
Alex: ???
Jarvis: Waiting to hear 'Jarvis'

It should not behave this way so I'll fix it but I don't have your error messages. Let's see if my fix resolves your issues.

@alexylem alexylem added this to the Je travaille dessus milestone May 4, 2017
alexylem added a commit that referenced this issue May 4, 2017
@alexylem
Copy link
Owner

alexylem commented May 4, 2017

Implémenté sur la branch beta. Pour le tester dès à présent:
Menu Settings > General > Branch > beta
Sinon attendre la mise à jour de ce weekend.

@QuentinCG
Copy link
Author

QuentinCG commented May 4, 2017

Works fine with the fix: ERROR: Order cannot be empty

Thanks

Note: We don't have the same error because I didn't specify audio input/output for now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants