Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Open Graph on page #708

Closed
gBaylaender opened this issue Aug 5, 2019 · 5 comments
Closed

Improve the Open Graph on page #708

gBaylaender opened this issue Aug 5, 2019 · 5 comments
Labels
enhancement
Milestone
2.0-M2

Comments

@gBaylaender
Copy link

Improve the Open Graph in order, when you share the link on social, the preview it's looking ugly. Is it possible to improve it?

https://ogp.me/

Image from iOS
@syjer
Copy link
Member

syjer commented Aug 5, 2019

good point. Additionally with the M2 release, we need to check how fb handle single page app.

Tools for preview: https://developers.facebook.com/tools/debug/sharing/

@syjer
Copy link
Member

syjer commented Aug 5, 2019

note:

As described in https://speakerdeck.com/sienatime/facebook-sharing-for-single-page-apps

FB does not execute js, so we can generate a server side rendered page if the user agent match.

Will need to test with linkedin and twitter too

@syjer syjer added this to the 2.0-M2 milestone Aug 5, 2019
@syjer
Copy link
Member

syjer commented Aug 5, 2019 •
edited
Loading

tool for preview in linkedin: https://www.linkedin.com/post-inspector/inspect/
tool for preview in twitter: https://cards-dev.twitter.com/validator
doc for twitter: https://developer.twitter.com/en/docs/tweets/optimize-with-cards/guides/getting-started

user agents: https://gist.github.com/Paratron/8676518

syjer added a commit that referenced this issue Aug 5, 2019
@syjer
#708 wip, initial stubs/code
675240d
syjer added a commit that referenced this issue Aug 6, 2019
@syjer
#708 additional work for while testing with twitter/linkedin
475d7bf
@syjer
Copy link
Member

syjer commented Aug 6, 2019

note, for fb use localtunnel

syjer added a commit that referenced this issue Aug 6, 2019
@syjer
#708 remove og:article:author
54d6407
syjer added a commit that referenced this issue Aug 6, 2019
@syjer
#708 change title
27f93d9
cbellone pushed a commit that referenced this issue Aug 6, 2019
@syjer @cbellone
implement #708 opengraph improvements (#710)
b03c372 
* #708 wip, initial stubs/code

* #708 additional work for while testing with twitter/linkedin

* #708 remove og:article:author

* #708 change title
syjer added a commit that referenced this issue Aug 7, 2019
@syjer
#708 add test+display the full event name, not the short name
982af90
@syjer
Copy link
Member

syjer commented Aug 14, 2019

considered done for M2.

@syjer syjer closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0-M2
Development

No branches or pull requests
2 participants
@syjer @gBaylaender